reject unpaired high surrogate in wchar_t string formatting#2101
Open
nabhan06 wants to merge 1 commit into
Open
reject unpaired high surrogate in wchar_t string formatting#2101nabhan06 wants to merge 1 commit into
nabhan06 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wide-string overload of ConvertStringArg in str_format runs each wchar_t through WideToUtf8 but never inspects the ShiftState after the loop, so a wide string ending on an unpaired UTF-16 high surrogate has only the first two bytes of a 4-byte sequence written while StrFormat("%ls", ...) still reports success, emitting truncated invalid UTF-8. The single-character path in ConvertWCharTImpl already rejects a lone high surrogate, so this adds the same saw_high_surrogate check after the loop to make the string path fail the same way. The regression test in convert_test.cc covers both a trailing high surrogate and a valid non-BMP code point so surrogate pairs keep working.